Allow Closure Compiler name mangling. #208
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Member
|
This require test cases. Also try difficult stuff i. e. selectors starting with numbers or dashes. .\5-x { }
.\- { } |
Author
|
Uh, sorry for the necropost, I have no clue how to write tests for this. According to http://timelessrepo.com/json-isnt-a-javascript-subset however, there are only two characters for which JSON won't evaluate in a Javascript interpreter, and both are separators, so I think it should be fine. (Definitely not saying this doesn't need tests, just saying that I'm not sure how to go about writing them.) |
Author
|
Bump? |
Member
|
As @sokra said, this PR isn't going to land without test cases to cover the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.